Commit b8c55ce2 authored by Loic Poulain's avatar Loic Poulain Committed by David S. Miller

net: wwan: Fix bit ops double shift

bit operation helpers such as test_bit, clear_bit, etc take bit
position as parameter and not value. Current usage causes double
shift => BIT(BIT(0)). Fix that in wwan_core and mhi_wwan_ctrl.

Fixes: 9a44c1cc ("net: Add a WWAN subsystem")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ebbcac3d
...@@ -7,9 +7,11 @@ ...@@ -7,9 +7,11 @@
#include <linux/wwan.h> #include <linux/wwan.h>
/* MHI wwan flags */ /* MHI wwan flags */
#define MHI_WWAN_DL_CAP BIT(0) enum mhi_wwan_flags {
#define MHI_WWAN_UL_CAP BIT(1) MHI_WWAN_DL_CAP,
#define MHI_WWAN_RX_REFILL BIT(2) MHI_WWAN_UL_CAP,
MHI_WWAN_RX_REFILL,
};
#define MHI_WWAN_MAX_MTU 0x8000 #define MHI_WWAN_MAX_MTU 0x8000
......
...@@ -26,7 +26,7 @@ static int wwan_major; ...@@ -26,7 +26,7 @@ static int wwan_major;
#define to_wwan_port(d) container_of(d, struct wwan_port, dev) #define to_wwan_port(d) container_of(d, struct wwan_port, dev)
/* WWAN port flags */ /* WWAN port flags */
#define WWAN_PORT_TX_OFF BIT(0) #define WWAN_PORT_TX_OFF 0
/** /**
* struct wwan_device - The structure that defines a WWAN device * struct wwan_device - The structure that defines a WWAN device
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment