Commit b8d65e96 authored by Alistair Popple's avatar Alistair Popple Committed by Michael Ellerman

powerpc/eeh-powernv: Fix unbalanced IRQ warning

pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
gets called from a loop if there are more outstanding events to
process, resulting in a warning due to enabling an already enabled
interrupt. Instead the interrupt should only be re-enabled once the
last outstanding event has been processed.
Tested-by: default avatarDaniel Axtens <dja@axtens.net>
Reported-by: default avatarDaniel Axtens <dja@axtens.net>
Signed-off-by: default avatarAlistair Popple <alistair@popple.id.au>
Acked-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 120d200a
...@@ -1478,7 +1478,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe) ...@@ -1478,7 +1478,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe)
} }
/* Unmask the event */ /* Unmask the event */
if (eeh_enabled()) if (ret == EEH_NEXT_ERR_NONE && eeh_enabled())
enable_irq(eeh_event_irq); enable_irq(eeh_event_irq);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment