Commit ba169c30 authored by Jesper Juhl's avatar Jesper Juhl Committed by Linus Torvalds

[PATCH] fix inlining related build failures in mxser.c

This fixes a build failure with gcc-3.4.1, where we use some functions
before we define them inline. 

The simple way to fix those is to simply un-inline the functions in
question. Since they are somewhat large that's what I did.

An alternative would be to rework the ordering of the file so the
functions are defined before their first use.
Signed-off-by: default avatarJesper juhl <juhl-lkml@dif.dk>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent a631fa30
...@@ -410,9 +410,9 @@ static void mxser_start(struct tty_struct *); ...@@ -410,9 +410,9 @@ static void mxser_start(struct tty_struct *);
static void mxser_hangup(struct tty_struct *); static void mxser_hangup(struct tty_struct *);
static void mxser_rs_break(struct tty_struct *, int); static void mxser_rs_break(struct tty_struct *, int);
static irqreturn_t mxser_interrupt(int, void *, struct pt_regs *); static irqreturn_t mxser_interrupt(int, void *, struct pt_regs *);
static inline void mxser_receive_chars(struct mxser_struct *, int *); static void mxser_receive_chars(struct mxser_struct *, int *);
static inline void mxser_transmit_chars(struct mxser_struct *); static void mxser_transmit_chars(struct mxser_struct *);
static inline void mxser_check_modem_status(struct mxser_struct *, int); static void mxser_check_modem_status(struct mxser_struct *, int);
static int mxser_block_til_ready(struct tty_struct *, struct file *, struct mxser_struct *); static int mxser_block_til_ready(struct tty_struct *, struct file *, struct mxser_struct *);
static int mxser_startup(struct mxser_struct *); static int mxser_startup(struct mxser_struct *);
static void mxser_shutdown(struct mxser_struct *); static void mxser_shutdown(struct mxser_struct *);
...@@ -1989,7 +1989,7 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs) ...@@ -1989,7 +1989,7 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
return handled; return handled;
} }
static inline void mxser_receive_chars(struct mxser_struct *info, int *status) static void mxser_receive_chars(struct mxser_struct *info, int *status)
{ {
struct tty_struct *tty = info->tty; struct tty_struct *tty = info->tty;
unsigned char ch, gdl; unsigned char ch, gdl;
...@@ -2143,7 +2143,7 @@ static inline void mxser_receive_chars(struct mxser_struct *info, int *status) ...@@ -2143,7 +2143,7 @@ static inline void mxser_receive_chars(struct mxser_struct *info, int *status)
} }
static inline void mxser_transmit_chars(struct mxser_struct *info) static void mxser_transmit_chars(struct mxser_struct *info)
{ {
int count, cnt; int count, cnt;
unsigned long flags; unsigned long flags;
...@@ -2206,7 +2206,7 @@ static inline void mxser_transmit_chars(struct mxser_struct *info) ...@@ -2206,7 +2206,7 @@ static inline void mxser_transmit_chars(struct mxser_struct *info)
spin_unlock_irqrestore(&info->slock, flags); spin_unlock_irqrestore(&info->slock, flags);
} }
static inline void mxser_check_modem_status(struct mxser_struct *info, int status) static void mxser_check_modem_status(struct mxser_struct *info, int status)
{ {
/* update input line counters */ /* update input line counters */
if (status & UART_MSR_TERI) if (status & UART_MSR_TERI)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment