Commit ba23dc64 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()

sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6dff5add
...@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf) ...@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)
/* power up and reset phy */ /* power up and reset phy */
sr_write_reg(dev, SR_PRR, PRR_PHY_RST); sr_write_reg(dev, SR_PRR, PRR_PHY_RST);
/* at least 10ms, here 20ms for safe */ /* at least 10ms, here 20ms for safe */
mdelay(20); msleep(20);
sr_write_reg(dev, SR_PRR, 0); sr_write_reg(dev, SR_PRR, 0);
/* at least 1ms, here 2ms for reading right register */ /* at least 1ms, here 2ms for reading right register */
udelay(2 * 1000); udelay(2 * 1000);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment