Commit ba3edf1f authored by Linus Torvalds's avatar Linus Torvalds

proc: show si_ptr in /proc/<pid>/timers without hashing

It's a user pointer, and while the permissions of the file are pretty
questionable (should it really be readable to everybody), hashing the
pointer isn't going to be the solution.

We should take a closer look at more of the /proc/<pid> file permissions
in general.  Sure, we do want many of them to often be readable (for
'ps' and friends), but I think we should probably do a few conversions
from S_IRUGO to S_IRUSR.
Reported-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 10f837e5
...@@ -2268,7 +2268,7 @@ static int show_timer(struct seq_file *m, void *v) ...@@ -2268,7 +2268,7 @@ static int show_timer(struct seq_file *m, void *v)
notify = timer->it_sigev_notify; notify = timer->it_sigev_notify;
seq_printf(m, "ID: %d\n", timer->it_id); seq_printf(m, "ID: %d\n", timer->it_id);
seq_printf(m, "signal: %d/%p\n", seq_printf(m, "signal: %d/%px\n",
timer->sigq->info.si_signo, timer->sigq->info.si_signo,
timer->sigq->info.si_value.sival_ptr); timer->sigq->info.si_value.sival_ptr);
seq_printf(m, "notify: %s/%s.%d\n", seq_printf(m, "notify: %s/%s.%d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment