Commit ba635374 authored by Stuart Hayes's avatar Stuart Hayes Committed by Greg Kroah-Hartman

driver core: don't always lock parent in shutdown

Don't lock a parent device unless it is needed in device_shutdown. This
is in preparation for making device shutdown asynchronous, when it will
be needed to allow children of a common parent to shut down
simultaneously.
Signed-off-by: default avatarStuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: default avatarDavid Jeffery <djeffery@redhat.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Tested-by: default avatarKeith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240822202805.6379-2-stuart.w.hayes@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 24e041e1
...@@ -4816,7 +4816,7 @@ void device_shutdown(void) ...@@ -4816,7 +4816,7 @@ void device_shutdown(void)
spin_unlock(&devices_kset->list_lock); spin_unlock(&devices_kset->list_lock);
/* hold lock to avoid race with probe/release */ /* hold lock to avoid race with probe/release */
if (parent) if (parent && dev->bus && dev->bus->need_parent_lock)
device_lock(parent); device_lock(parent);
device_lock(dev); device_lock(dev);
...@@ -4840,7 +4840,7 @@ void device_shutdown(void) ...@@ -4840,7 +4840,7 @@ void device_shutdown(void)
} }
device_unlock(dev); device_unlock(dev);
if (parent) if (parent && dev->bus && dev->bus->need_parent_lock)
device_unlock(parent); device_unlock(parent);
put_device(dev); put_device(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment