Commit bbacb274 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mauro Carvalho Chehab

media: ipu3-cio2: Simplify cleanup code

The code looks more nicer if we use:
	while (i--)
instead:
	for (i = i - 1; i >= 0; i--)

This would also allow making 'i' unsigned again.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d8fc21c1
...@@ -847,7 +847,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb) ...@@ -847,7 +847,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb)
unsigned int lops = DIV_ROUND_UP(pages + 1, entries_per_page); unsigned int lops = DIV_ROUND_UP(pages + 1, entries_per_page);
struct sg_table *sg; struct sg_table *sg;
struct sg_dma_page_iter sg_iter; struct sg_dma_page_iter sg_iter;
int i, j; unsigned int i, j;
if (lops <= 0 || lops > CIO2_MAX_LOPS) { if (lops <= 0 || lops > CIO2_MAX_LOPS) {
dev_err(dev, "%s: bad buffer size (%i)\n", __func__, dev_err(dev, "%s: bad buffer size (%i)\n", __func__,
...@@ -887,7 +887,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb) ...@@ -887,7 +887,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb)
b->lop[i][j] = cio2->dummy_page_bus_addr >> PAGE_SHIFT; b->lop[i][j] = cio2->dummy_page_bus_addr >> PAGE_SHIFT;
return 0; return 0;
fail: fail:
for (i--; i >= 0; i--) while (i--)
dma_free_coherent(dev, CIO2_PAGE_SIZE, dma_free_coherent(dev, CIO2_PAGE_SIZE,
b->lop[i], b->lop_bus_addr[i]); b->lop[i], b->lop_bus_addr[i]);
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment