Commit bc01a8c7 authored by Alex Deucher's avatar Alex Deucher

drm/radeon: update line buffer allocation for dce8

We need to allocate line buffer to each display when
setting up the watermarks.  Failure to do so can lead
to a blank screen.  This fixes blank screen problems
on dce8 asics.

Based on an initial fix from:
Jay Cornwall <jay.cornwall@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
parent 290d2457
...@@ -7367,8 +7367,8 @@ static u32 dce8_line_buffer_adjust(struct radeon_device *rdev, ...@@ -7367,8 +7367,8 @@ static u32 dce8_line_buffer_adjust(struct radeon_device *rdev,
struct radeon_crtc *radeon_crtc, struct radeon_crtc *radeon_crtc,
struct drm_display_mode *mode) struct drm_display_mode *mode)
{ {
u32 tmp; u32 tmp, buffer_alloc, i;
u32 pipe_offset = radeon_crtc->crtc_id * 0x20;
/* /*
* Line Buffer Setup * Line Buffer Setup
* There are 6 line buffers, one for each display controllers. * There are 6 line buffers, one for each display controllers.
...@@ -7378,22 +7378,37 @@ static u32 dce8_line_buffer_adjust(struct radeon_device *rdev, ...@@ -7378,22 +7378,37 @@ static u32 dce8_line_buffer_adjust(struct radeon_device *rdev,
* them using the stereo blender. * them using the stereo blender.
*/ */
if (radeon_crtc->base.enabled && mode) { if (radeon_crtc->base.enabled && mode) {
if (mode->crtc_hdisplay < 1920) if (mode->crtc_hdisplay < 1920) {
tmp = 1; tmp = 1;
else if (mode->crtc_hdisplay < 2560) buffer_alloc = 2;
} else if (mode->crtc_hdisplay < 2560) {
tmp = 2; tmp = 2;
else if (mode->crtc_hdisplay < 4096) buffer_alloc = 2;
} else if (mode->crtc_hdisplay < 4096) {
tmp = 0; tmp = 0;
else { buffer_alloc = (rdev->flags & RADEON_IS_IGP) ? 2 : 4;
} else {
DRM_DEBUG_KMS("Mode too big for LB!\n"); DRM_DEBUG_KMS("Mode too big for LB!\n");
tmp = 0; tmp = 0;
buffer_alloc = (rdev->flags & RADEON_IS_IGP) ? 2 : 4;
} }
} else } else {
tmp = 1; tmp = 1;
buffer_alloc = 0;
}
WREG32(LB_MEMORY_CTRL + radeon_crtc->crtc_offset, WREG32(LB_MEMORY_CTRL + radeon_crtc->crtc_offset,
LB_MEMORY_CONFIG(tmp) | LB_MEMORY_SIZE(0x6B0)); LB_MEMORY_CONFIG(tmp) | LB_MEMORY_SIZE(0x6B0));
WREG32(PIPE0_DMIF_BUFFER_CONTROL + pipe_offset,
DMIF_BUFFERS_ALLOCATED(buffer_alloc));
for (i = 0; i < rdev->usec_timeout; i++) {
if (RREG32(PIPE0_DMIF_BUFFER_CONTROL + pipe_offset) &
DMIF_BUFFERS_ALLOCATED_COMPLETED)
break;
udelay(1);
}
if (radeon_crtc->base.enabled && mode) { if (radeon_crtc->base.enabled && mode) {
switch (tmp) { switch (tmp) {
case 0: case 0:
......
...@@ -393,6 +393,10 @@ ...@@ -393,6 +393,10 @@
#define DMIF_ADDR_CALC 0xC00 #define DMIF_ADDR_CALC 0xC00
#define PIPE0_DMIF_BUFFER_CONTROL 0x0ca0
# define DMIF_BUFFERS_ALLOCATED(x) ((x) << 0)
# define DMIF_BUFFERS_ALLOCATED_COMPLETED (1 << 4)
#define SRBM_GFX_CNTL 0xE44 #define SRBM_GFX_CNTL 0xE44
#define PIPEID(x) ((x) << 0) #define PIPEID(x) ((x) << 0)
#define MEID(x) ((x) << 2) #define MEID(x) ((x) << 2)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment