Commit bc4854bc authored by Cong Wang's avatar Cong Wang Committed by Philipp Reisner

drbd: check MODULE for THIS_MODULE

THIS_MODULE is NULL only when drbd is compiled as built-in,
so the #ifdef CONFIG_MODULES should be #ifdef MODULE instead.

This fixes the warning:

drivers/block/drbd/drbd_main.c: In function ‘drbd_buildtag’:
drivers/block/drbd/drbd_main.c:4187:24: warning: the comparison will always evaluate as ‘true’ for the address of ‘__this_module’ will never be NULL [-Waddress]
Signed-off-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
parent f6d0a8db
...@@ -4365,12 +4365,11 @@ const char *drbd_buildtag(void) ...@@ -4365,12 +4365,11 @@ const char *drbd_buildtag(void)
static char buildtag[38] = "\0uilt-in"; static char buildtag[38] = "\0uilt-in";
if (buildtag[0] == 0) { if (buildtag[0] == 0) {
#ifdef CONFIG_MODULES #ifdef MODULE
if (THIS_MODULE != NULL) sprintf(buildtag, "srcversion: %-24s", THIS_MODULE->srcversion);
sprintf(buildtag, "srcversion: %-24s", THIS_MODULE->srcversion); #else
else buildtag[0] = 'b';
#endif #endif
buildtag[0] = 'b';
} }
return buildtag; return buildtag;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment