Commit bd01dd8b authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Greg Kroah-Hartman

s390/qeth: on channel error, reject further cmd requests


[ Upstream commit a6c3d939 ]

When the IRQ handler determines that one of the cmd IO channels has
failed and schedules recovery, block any further cmd requests from
being submitted. The request would inevitably stall, and prevent the
recovery from making progress until the request times out.

This sort of error was observed after Live Guest Relocation, where
the pending IO on the READ channel intentionally gets terminated to
kick-start recovery. Simultaneously the guest executed SIOCETHTOOL,
triggering qeth to issue a QUERY CARD INFO command. The command
then stalled in the inoperabel WRITE channel.
Signed-off-by: default avatarJulian Wiedmann <jwi@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e960fa03
...@@ -1166,6 +1166,7 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm, ...@@ -1166,6 +1166,7 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm,
} }
rc = qeth_get_problem(cdev, irb); rc = qeth_get_problem(cdev, irb);
if (rc) { if (rc) {
card->read_or_write_problem = 1;
qeth_clear_ipacmd_list(card); qeth_clear_ipacmd_list(card);
qeth_schedule_recovery(card); qeth_schedule_recovery(card);
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment