Commit bd6fc7f0 authored by Maxime Ripard's avatar Maxime Ripard Committed by Luis Henriques

net: mvneta: Fix CPU_MAP registers initialisation

commit 2502d0ef upstream.

The CPU_MAP register is duplicated for each CPUs at different addresses,
each instance being at a different address.

However, the code so far was using CONFIG_NR_CPUS to initialise the CPU_MAP
registers for each registers, while the SoCs embed at most 4 CPUs.

This is especially an issue with multi_v7_defconfig, where CONFIG_NR_CPUS
is currently set to 16, resulting in writes to registers that are not
CPU_MAP.

Fixes: c5aff182 ("net: mvneta: driver for Marvell Armada 370/XP network unit")
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 8929f690
...@@ -941,7 +941,7 @@ static void mvneta_defaults_set(struct mvneta_port *pp) ...@@ -941,7 +941,7 @@ static void mvneta_defaults_set(struct mvneta_port *pp)
/* Set CPU queue access map - all CPUs have access to all RX /* Set CPU queue access map - all CPUs have access to all RX
* queues and to all TX queues * queues and to all TX queues
*/ */
for (cpu = 0; cpu < CONFIG_NR_CPUS; cpu++) for_each_present_cpu(cpu)
mvreg_write(pp, MVNETA_CPU_MAP(cpu), mvreg_write(pp, MVNETA_CPU_MAP(cpu),
(MVNETA_CPU_RXQ_ACCESS_ALL_MASK | (MVNETA_CPU_RXQ_ACCESS_ALL_MASK |
MVNETA_CPU_TXQ_ACCESS_ALL_MASK)); MVNETA_CPU_TXQ_ACCESS_ALL_MASK));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment