Commit be6a83dd authored by Johannes Berg's avatar Johannes Berg Committed by Jaroslav Kysela

[ALSA] aoa: platform function gpio: ignore errors from functions that don't exist

Sometimes we simply want to turn off or on everything, and when recently a
warning was added when a certain platform function can't be called, this
triggered all the time in those cases. This patch shows the warning only if
the error was different from the function not existing.
The alternative would be to not even try calling the function when it
doesn't exist by first checking which exist and then only calling those that
do, but that adds complexity that isn't necessary.
Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@suse.cz>
parent 545b07d3
...@@ -18,7 +18,7 @@ static void pmf_gpio_set_##name(struct gpio_runtime *rt, int on)\ ...@@ -18,7 +18,7 @@ static void pmf_gpio_set_##name(struct gpio_runtime *rt, int on)\
\ \
if (unlikely(!rt)) return; \ if (unlikely(!rt)) return; \
rc = pmf_call_function(rt->node, #name "-mute", &args); \ rc = pmf_call_function(rt->node, #name "-mute", &args); \
if (rc) \ if (rc && rc != -ENODEV) \
printk(KERN_WARNING "pmf_gpio_set_" #name \ printk(KERN_WARNING "pmf_gpio_set_" #name \
" failed, rc: %d\n", rc); \ " failed, rc: %d\n", rc); \
rt->implementation_private &= ~(1<<bit); \ rt->implementation_private &= ~(1<<bit); \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment