Commit bf5ac277 authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luis Henriques

iwlwifi: dvm: run INIT firmware again upon .start()

commit 9c8928f5 upstream.

The assumption before this patch was that we don't need to
run again the INIT firmware after the system booted. The
INIT firmware runs calibrations which impact the physical
layer's behavior.
Users reported that it may be helpful to run these
calibrations again every time the interface is brought up.
The penatly is minimal, since the calibrations run fast.
This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=94341Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 5c2a7d6e
...@@ -708,7 +708,6 @@ struct iwl_priv { ...@@ -708,7 +708,6 @@ struct iwl_priv {
unsigned long reload_jiffies; unsigned long reload_jiffies;
int reload_count; int reload_count;
bool ucode_loaded; bool ucode_loaded;
bool init_ucode_run; /* Don't run init uCode again */
u8 plcp_delta_threshold; u8 plcp_delta_threshold;
......
...@@ -418,9 +418,6 @@ int iwl_run_init_ucode(struct iwl_priv *priv) ...@@ -418,9 +418,6 @@ int iwl_run_init_ucode(struct iwl_priv *priv)
if (!priv->fw->img[IWL_UCODE_INIT].sec[0].len) if (!priv->fw->img[IWL_UCODE_INIT].sec[0].len)
return 0; return 0;
if (priv->init_ucode_run)
return 0;
iwl_init_notification_wait(&priv->notif_wait, &calib_wait, iwl_init_notification_wait(&priv->notif_wait, &calib_wait,
calib_complete, ARRAY_SIZE(calib_complete), calib_complete, ARRAY_SIZE(calib_complete),
iwlagn_wait_calib, priv); iwlagn_wait_calib, priv);
...@@ -440,8 +437,6 @@ int iwl_run_init_ucode(struct iwl_priv *priv) ...@@ -440,8 +437,6 @@ int iwl_run_init_ucode(struct iwl_priv *priv)
*/ */
ret = iwl_wait_notification(&priv->notif_wait, &calib_wait, ret = iwl_wait_notification(&priv->notif_wait, &calib_wait,
UCODE_CALIB_TIMEOUT); UCODE_CALIB_TIMEOUT);
if (!ret)
priv->init_ucode_run = true;
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment