Commit bf6abf34 authored by Erik Ekman's avatar Erik Ekman Committed by David S. Miller

sfc: Don't use netif_info before net_device setup

Use pci_info instead to avoid unnamed/uninitialized noise:

[197088.688729] sfc 0000:01:00.0: Solarflare NIC detected
[197088.690333] sfc 0000:01:00.0: Part Number : SFN5122F
[197088.729061] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no SR-IOV VFs probed
[197088.729071] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no PTP support

Inspired by fa44821a ("sfc: don't use netif_info et al before
net_device is registered") from Heiner Kallweit.
Signed-off-by: default avatarErik Ekman <erik@kryo.se>
Acked-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c62041c5
...@@ -648,7 +648,7 @@ static int efx_ptp_get_attributes(struct efx_nic *efx) ...@@ -648,7 +648,7 @@ static int efx_ptp_get_attributes(struct efx_nic *efx)
} else if (rc == -EINVAL) { } else if (rc == -EINVAL) {
fmt = MC_CMD_PTP_OUT_GET_ATTRIBUTES_SECONDS_NANOSECONDS; fmt = MC_CMD_PTP_OUT_GET_ATTRIBUTES_SECONDS_NANOSECONDS;
} else if (rc == -EPERM) { } else if (rc == -EPERM) {
netif_info(efx, probe, efx->net_dev, "no PTP support\n"); pci_info(efx->pci_dev, "no PTP support\n");
return rc; return rc;
} else { } else {
efx_mcdi_display_error(efx, MC_CMD_PTP, sizeof(inbuf), efx_mcdi_display_error(efx, MC_CMD_PTP, sizeof(inbuf),
...@@ -824,7 +824,7 @@ static int efx_ptp_disable(struct efx_nic *efx) ...@@ -824,7 +824,7 @@ static int efx_ptp_disable(struct efx_nic *efx)
* should only have been called during probe. * should only have been called during probe.
*/ */
if (rc == -ENOSYS || rc == -EPERM) if (rc == -ENOSYS || rc == -EPERM)
netif_info(efx, probe, efx->net_dev, "no PTP support\n"); pci_info(efx->pci_dev, "no PTP support\n");
else if (rc) else if (rc)
efx_mcdi_display_error(efx, MC_CMD_PTP, efx_mcdi_display_error(efx, MC_CMD_PTP,
MC_CMD_PTP_IN_DISABLE_LEN, MC_CMD_PTP_IN_DISABLE_LEN,
......
...@@ -1057,7 +1057,7 @@ void efx_siena_sriov_probe(struct efx_nic *efx) ...@@ -1057,7 +1057,7 @@ void efx_siena_sriov_probe(struct efx_nic *efx)
return; return;
if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count)) { if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count)) {
netif_info(efx, probe, efx->net_dev, "no SR-IOV VFs probed\n"); pci_info(efx->pci_dev, "no SR-IOV VFs probed\n");
return; return;
} }
if (count > 0 && count > max_vfs) if (count > 0 && count > max_vfs)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment