Commit bf6b47de authored by Jesper Juhl's avatar Jesper Juhl Committed by Roland Dreier

IB/mlx4: Fix memory leaks in ib_link_query_port()

If the call to mlx4_MAD_IFC() fails in ib_link_query_port() we will
currently do 'return err;' which will leak 'in_mad' and 'out_mad'.  We
should instead do 'goto out;' where we'll properly free the memory we
previously allocated.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Acked-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 00341028
...@@ -247,7 +247,7 @@ static int ib_link_query_port(struct ib_device *ibdev, u8 port, ...@@ -247,7 +247,7 @@ static int ib_link_query_port(struct ib_device *ibdev, u8 port,
err = mlx4_MAD_IFC(to_mdev(ibdev), 1, 1, port, err = mlx4_MAD_IFC(to_mdev(ibdev), 1, 1, port,
NULL, NULL, in_mad, out_mad); NULL, NULL, in_mad, out_mad);
if (err) if (err)
return err; goto out;
/* Checking LinkSpeedActive for FDR-10 */ /* Checking LinkSpeedActive for FDR-10 */
if (out_mad->data[15] & 0x1) if (out_mad->data[15] & 0x1)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment