Commit bfb59b12 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Luis Henriques

nfsd4: fix crash on unknown operation number

commit 51904b08 upstream.

Unknown operation numbers are caught in nfsd4_decode_compound() which
sets op->opnum to OP_ILLEGAL and op->status to nfserr_op_illegal.  The
error causes the main loop in nfsd4_proc_compound() to skip most
processing.  But nfsd4_proc_compound also peeks ahead at the next
operation in one case and doesn't take similar precautions there.
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 80a4a2cd
...@@ -1231,7 +1231,8 @@ static bool need_wrongsec_check(struct svc_rqst *rqstp) ...@@ -1231,7 +1231,8 @@ static bool need_wrongsec_check(struct svc_rqst *rqstp)
*/ */
if (argp->opcnt == resp->opcnt) if (argp->opcnt == resp->opcnt)
return false; return false;
if (next->opnum == OP_ILLEGAL)
return false;
nextd = OPDESC(next); nextd = OPDESC(next);
/* /*
* Rest of 2.6.3.1.1: certain operations will return WRONGSEC * Rest of 2.6.3.1.1: certain operations will return WRONGSEC
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment