Commit bfec73d7 authored by Allan Stephens's avatar Allan Stephens Committed by Paul Gortmaker

tipc: Revise comment justifying release of configuration spinlock

Comment-only change to better explain why TIPC's configuration lock is
temporarily released while activating support for network interfaces,
and why the existing activation code doesn't require rework.
Signed-off-by: default avatarAllan Stephens <allan.stephens@windriver.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent 5c216e1d
...@@ -184,13 +184,12 @@ static struct sk_buff *cfg_set_own_addr(void) ...@@ -184,13 +184,12 @@ static struct sk_buff *cfg_set_own_addr(void)
" (cannot change node address once assigned)"); " (cannot change node address once assigned)");
/* /*
* Must release all spinlocks before calling start_net() because * Must temporarily release configuration spinlock while switching into
* Linux version of TIPC calls eth_media_start() which calls * networking mode as it calls tipc_eth_media_start(), which may sleep.
* register_netdevice_notifier() which may block! * Releasing the lock is harmless as other locally-issued configuration
* * commands won't occur until this one completes, and remotely-issued
* Temporarily releasing the lock should be harmless for non-Linux TIPC, * configuration commands can't be received until a local configuration
* but Linux version of eth_media_start() should really be reworked * command to enable the first bearer is received and processed.
* so that it can be called with spinlocks held.
*/ */
spin_unlock_bh(&config_lock); spin_unlock_bh(&config_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment