Commit c0c682ee authored by Shannon Nelson's avatar Shannon Nelson Committed by Jakub Kicinski

ionic: remove some unnecessary oom messages

Remove memory allocation fail messages where the OOM stack
trace will make it obvious which allocation request failed.
Signed-off-by: default avatarShannon Nelson <snelson@pensando.io>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 832913c3
...@@ -142,7 +142,7 @@ int ionic_heartbeat_check(struct ionic *ionic) ...@@ -142,7 +142,7 @@ int ionic_heartbeat_check(struct ionic *ionic)
work = kzalloc(sizeof(*work), GFP_ATOMIC); work = kzalloc(sizeof(*work), GFP_ATOMIC);
if (!work) { if (!work) {
dev_err(ionic->dev, "%s OOM\n", __func__); dev_err(ionic->dev, "LIF reset trigger dropped\n");
} else { } else {
work->type = IONIC_DW_TYPE_LIF_RESET; work->type = IONIC_DW_TYPE_LIF_RESET;
if (fw_status & IONIC_FW_STS_F_RUNNING && if (fw_status & IONIC_FW_STS_F_RUNNING &&
......
...@@ -842,7 +842,7 @@ static bool ionic_notifyq_service(struct ionic_cq *cq, ...@@ -842,7 +842,7 @@ static bool ionic_notifyq_service(struct ionic_cq *cq,
case IONIC_EVENT_RESET: case IONIC_EVENT_RESET:
work = kzalloc(sizeof(*work), GFP_ATOMIC); work = kzalloc(sizeof(*work), GFP_ATOMIC);
if (!work) { if (!work) {
netdev_err(lif->netdev, "%s OOM\n", __func__); netdev_err(lif->netdev, "Reset event dropped\n");
} else { } else {
work->type = IONIC_DW_TYPE_LIF_RESET; work->type = IONIC_DW_TYPE_LIF_RESET;
ionic_lif_deferred_enqueue(&lif->deferred, work); ionic_lif_deferred_enqueue(&lif->deferred, work);
...@@ -1051,10 +1051,8 @@ static int ionic_lif_addr(struct ionic_lif *lif, const u8 *addr, bool add, ...@@ -1051,10 +1051,8 @@ static int ionic_lif_addr(struct ionic_lif *lif, const u8 *addr, bool add,
if (!can_sleep) { if (!can_sleep) {
work = kzalloc(sizeof(*work), GFP_ATOMIC); work = kzalloc(sizeof(*work), GFP_ATOMIC);
if (!work) { if (!work)
netdev_err(lif->netdev, "%s OOM\n", __func__);
return -ENOMEM; return -ENOMEM;
}
work->type = add ? IONIC_DW_TYPE_RX_ADDR_ADD : work->type = add ? IONIC_DW_TYPE_RX_ADDR_ADD :
IONIC_DW_TYPE_RX_ADDR_DEL; IONIC_DW_TYPE_RX_ADDR_DEL;
memcpy(work->addr, addr, ETH_ALEN); memcpy(work->addr, addr, ETH_ALEN);
...@@ -1183,7 +1181,7 @@ static void ionic_set_rx_mode(struct net_device *netdev, bool can_sleep) ...@@ -1183,7 +1181,7 @@ static void ionic_set_rx_mode(struct net_device *netdev, bool can_sleep)
if (!can_sleep) { if (!can_sleep) {
work = kzalloc(sizeof(*work), GFP_ATOMIC); work = kzalloc(sizeof(*work), GFP_ATOMIC);
if (!work) { if (!work) {
netdev_err(lif->netdev, "%s OOM\n", __func__); netdev_err(lif->netdev, "rxmode change dropped\n");
return; return;
} }
work->type = IONIC_DW_TYPE_RX_MODE; work->type = IONIC_DW_TYPE_RX_MODE;
......
...@@ -511,10 +511,8 @@ int ionic_port_init(struct ionic *ionic) ...@@ -511,10 +511,8 @@ int ionic_port_init(struct ionic *ionic)
idev->port_info_sz, idev->port_info_sz,
&idev->port_info_pa, &idev->port_info_pa,
GFP_KERNEL); GFP_KERNEL);
if (!idev->port_info) { if (!idev->port_info)
dev_err(ionic->dev, "Failed to allocate port info\n");
return -ENOMEM; return -ENOMEM;
}
} }
sz = min(sizeof(ident->port.config), sizeof(idev->dev_cmd_regs->data)); sz = min(sizeof(ident->port.config), sizeof(idev->dev_cmd_regs->data));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment