Commit c1da86c1 authored by Arvind Yadav's avatar Arvind Yadav Committed by Tejun Heo

pata_pdc2027x: Remove unnecessary error check

Here, The function pdc_hardware_init always return zero. So it is not
necessary to check its return value.
Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 16a27dfd
...@@ -649,7 +649,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host) ...@@ -649,7 +649,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host)
* @host: target ATA host * @host: target ATA host
* @board_idx: board identifier * @board_idx: board identifier
*/ */
static int pdc_hardware_init(struct ata_host *host, unsigned int board_idx) static void pdc_hardware_init(struct ata_host *host, unsigned int board_idx)
{ {
long pll_clock; long pll_clock;
...@@ -665,8 +665,6 @@ static int pdc_hardware_init(struct ata_host *host, unsigned int board_idx) ...@@ -665,8 +665,6 @@ static int pdc_hardware_init(struct ata_host *host, unsigned int board_idx)
/* Adjust PLL control register */ /* Adjust PLL control register */
pdc_adjust_pll(host, pll_clock, board_idx); pdc_adjust_pll(host, pll_clock, board_idx);
return 0;
} }
/** /**
...@@ -753,8 +751,7 @@ static int pdc2027x_init_one(struct pci_dev *pdev, ...@@ -753,8 +751,7 @@ static int pdc2027x_init_one(struct pci_dev *pdev,
//pci_enable_intx(pdev); //pci_enable_intx(pdev);
/* initialize adapter */ /* initialize adapter */
if (pdc_hardware_init(host, board_idx) != 0) pdc_hardware_init(host, board_idx);
return -EIO;
pci_set_master(pdev); pci_set_master(pdev);
return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt, return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt,
...@@ -778,8 +775,7 @@ static int pdc2027x_reinit_one(struct pci_dev *pdev) ...@@ -778,8 +775,7 @@ static int pdc2027x_reinit_one(struct pci_dev *pdev)
else else
board_idx = PDC_UDMA_133; board_idx = PDC_UDMA_133;
if (pdc_hardware_init(host, board_idx)) pdc_hardware_init(host, board_idx);
return -EIO;
ata_host_resume(host); ata_host_resume(host);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment