Commit c31f0ea7 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller

mlxsw: spectrum_cnt: Fix 64-bit division in mlxsw_sp_counter_resources_register

When building arm32 allyesconfig:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by spectrum_cnt.c
>>>               net/ethernet/mellanox/mlxsw/spectrum_cnt.o:(mlxsw_sp_counter_resources_register) in archive drivers/built-in.a
>>> did you mean: __aeabi_uidivmod
>>> defined in: arch/arm/lib/lib.a(lib1funcs.o)

pool_size and bank_size are u64; use div64_u64 so that 32-bit platforms
do not error.

Fixes: ab8c4cc6 ("mlxsw: spectrum_cnt: Move config validation along with resource register")
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0dfb2d82
...@@ -303,7 +303,7 @@ int mlxsw_sp_counter_resources_register(struct mlxsw_core *mlxsw_core) ...@@ -303,7 +303,7 @@ int mlxsw_sp_counter_resources_register(struct mlxsw_core *mlxsw_core)
} }
/* Check config is valid, no bank over subscription */ /* Check config is valid, no bank over subscription */
if (WARN_ON(total_bank_config > pool_size / bank_size + 1)) if (WARN_ON(total_bank_config > div64_u64(pool_size, bank_size) + 1))
return -EINVAL; return -EINVAL;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment