Commit c3b6f755 authored by Lipeng's avatar Lipeng Committed by David S. Miller

net: hns3: fix the bug when reuse command description in hclge_add_mac_vlan_tbl

When reusing a command description read from HW, driver should set
IN_VLD bit, WR bit and NO_INTR bit. If IN_VLD bit and NO_INTR bit
are not set, the command fails and driver prints error message:

[  135.261284] hns3 0000:7d:00.0: cmdq execute failed for get_mac_vlan_cmd_status,status=2.
[  135.270983] hns3 0000:7d:00.0: add mac addr failed for cmd_send, ret =-5.

This patch fixes the bug.
Fixes: 46a3df9f (net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support)
Signed-off-by: default avatarLipeng <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a17dcf3f
...@@ -3600,11 +3600,11 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport, ...@@ -3600,11 +3600,11 @@ static int hclge_add_mac_vlan_tbl(struct hclge_vport *vport,
resp_code, resp_code,
HCLGE_MAC_VLAN_ADD); HCLGE_MAC_VLAN_ADD);
} else { } else {
mc_desc[0].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_WR); hclge_cmd_reuse_desc(&mc_desc[0], false);
mc_desc[0].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT); mc_desc[0].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
mc_desc[1].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_WR); hclge_cmd_reuse_desc(&mc_desc[1], false);
mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT); mc_desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_WR); hclge_cmd_reuse_desc(&mc_desc[2], false);
mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT); mc_desc[2].flag &= cpu_to_le16(~HCLGE_CMD_FLAG_NEXT);
memcpy(mc_desc[0].data, req, memcpy(mc_desc[0].data, req,
sizeof(struct hclge_mac_vlan_tbl_entry_cmd)); sizeof(struct hclge_mac_vlan_tbl_entry_cmd));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment