Commit c3df30a0 authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Mauro Carvalho Chehab

media: aspeed-video: Fix memory leaks in aspeed_video_probe

In the implementation of aspeed_video_probe() the allocated memory for
video should be released if either devm_ioremap_resource()
or aspeed_video_init() or aspeed_video_setup_video() fails. Replace
kzalloc() with devm_kzalloc to avoid explicit release for video.

Fixes: d2b4387f ("media: platform: Add Aspeed Video Engine driver")
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: default avatarJae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: default avatarEddie James <eajames@linux.ibm.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 99cf8a70
...@@ -1657,7 +1657,8 @@ static int aspeed_video_probe(struct platform_device *pdev) ...@@ -1657,7 +1657,8 @@ static int aspeed_video_probe(struct platform_device *pdev)
{ {
int rc; int rc;
struct resource *res; struct resource *res;
struct aspeed_video *video = kzalloc(sizeof(*video), GFP_KERNEL); struct aspeed_video *video =
devm_kzalloc(&pdev->dev, sizeof(*video), GFP_KERNEL);
if (!video) if (!video)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment