Commit c49fcb5c authored by Erico Nunes's avatar Erico Nunes Committed by Qiang Yu

drm/lima: avoid error task dump attempt when not enabled

Currently when users try to run an application with lima and that hits
an issue such as a timeout, a message saying "fail to save task state"
and "error task list is full" is shown in dmesg.

The error task dump is a debug feature disabled by default, so the
error task list is usually not going to be available at all.
The message can be misleading and creates confusion in bug reports.

We can avoid that code path and that particular message when the user
has not explicitly set the max_error_tasks parameter to enable the
feature.
Signed-off-by: default avatarErico Nunes <nunes.erico@gmail.com>
Reviewed-by: default avatarQiang Yu <yuq825@gmail.com>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarQiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220209093700.30901-1-nunes.erico@gmail.com
parent c7703ce3
...@@ -409,7 +409,8 @@ static enum drm_gpu_sched_stat lima_sched_timedout_job(struct drm_sched_job *job ...@@ -409,7 +409,8 @@ static enum drm_gpu_sched_stat lima_sched_timedout_job(struct drm_sched_job *job
drm_sched_increase_karma(&task->base); drm_sched_increase_karma(&task->base);
lima_sched_build_error_task_list(task); if (lima_max_error_tasks)
lima_sched_build_error_task_list(task);
pipe->task_error(pipe); pipe->task_error(pipe);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment