Commit c51dfff8 authored by David S. Miller's avatar David S. Miller

Merge branch 'gtp-simple-improvements'

Andreas Schultz says:

====================
gtp: simple gtp improvements

This is the part of the previous "simple gtp improvements" series
that Pablo indicated should go into net-next.

The rcu_lock removal is small correctness changes. Passing invalid
to user space allows for more standards compliant handling of invalid
tunnels.
====================
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 4e8f2fc1 1796a81d
...@@ -183,7 +183,6 @@ static int gtp0_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb, ...@@ -183,7 +183,6 @@ static int gtp0_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
sizeof(struct gtp0_header); sizeof(struct gtp0_header);
struct gtp0_header *gtp0; struct gtp0_header *gtp0;
struct pdp_ctx *pctx; struct pdp_ctx *pctx;
int ret = 0;
if (!pskb_may_pull(skb, hdrlen)) if (!pskb_may_pull(skb, hdrlen))
return -1; return -1;
...@@ -196,26 +195,19 @@ static int gtp0_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb, ...@@ -196,26 +195,19 @@ static int gtp0_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
if (gtp0->type != GTP_TPDU) if (gtp0->type != GTP_TPDU)
return 1; return 1;
rcu_read_lock();
pctx = gtp0_pdp_find(gtp, be64_to_cpu(gtp0->tid)); pctx = gtp0_pdp_find(gtp, be64_to_cpu(gtp0->tid));
if (!pctx) { if (!pctx) {
netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb); netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb);
ret = -1; return 1;
goto out_rcu;
} }
if (!gtp_check_src_ms(skb, pctx, hdrlen)) { if (!gtp_check_src_ms(skb, pctx, hdrlen)) {
netdev_dbg(gtp->dev, "No PDP ctx for this MS\n"); netdev_dbg(gtp->dev, "No PDP ctx for this MS\n");
ret = -1; return 1;
goto out_rcu;
} }
rcu_read_unlock();
/* Get rid of the GTP + UDP headers. */ /* Get rid of the GTP + UDP headers. */
return iptunnel_pull_header(skb, hdrlen, skb->protocol, xnet); return iptunnel_pull_header(skb, hdrlen, skb->protocol, xnet);
out_rcu:
rcu_read_unlock();
return ret;
} }
static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb, static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
...@@ -225,7 +217,6 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb, ...@@ -225,7 +217,6 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
sizeof(struct gtp1_header); sizeof(struct gtp1_header);
struct gtp1_header *gtp1; struct gtp1_header *gtp1;
struct pdp_ctx *pctx; struct pdp_ctx *pctx;
int ret = 0;
if (!pskb_may_pull(skb, hdrlen)) if (!pskb_may_pull(skb, hdrlen))
return -1; return -1;
...@@ -253,26 +244,19 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb, ...@@ -253,26 +244,19 @@ static int gtp1u_udp_encap_recv(struct gtp_dev *gtp, struct sk_buff *skb,
gtp1 = (struct gtp1_header *)(skb->data + sizeof(struct udphdr)); gtp1 = (struct gtp1_header *)(skb->data + sizeof(struct udphdr));
rcu_read_lock();
pctx = gtp1_pdp_find(gtp, ntohl(gtp1->tid)); pctx = gtp1_pdp_find(gtp, ntohl(gtp1->tid));
if (!pctx) { if (!pctx) {
netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb); netdev_dbg(gtp->dev, "No PDP ctx to decap skb=%p\n", skb);
ret = -1; return 1;
goto out_rcu;
} }
if (!gtp_check_src_ms(skb, pctx, hdrlen)) { if (!gtp_check_src_ms(skb, pctx, hdrlen)) {
netdev_dbg(gtp->dev, "No PDP ctx for this MS\n"); netdev_dbg(gtp->dev, "No PDP ctx for this MS\n");
ret = -1; return 1;
goto out_rcu;
} }
rcu_read_unlock();
/* Get rid of the GTP + UDP headers. */ /* Get rid of the GTP + UDP headers. */
return iptunnel_pull_header(skb, hdrlen, skb->protocol, xnet); return iptunnel_pull_header(skb, hdrlen, skb->protocol, xnet);
out_rcu:
rcu_read_unlock();
return ret;
} }
static void gtp_encap_disable(struct gtp_dev *gtp) static void gtp_encap_disable(struct gtp_dev *gtp)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment