Commit c6001025 authored by Asutosh Das's avatar Asutosh Das Committed by Martin K. Petersen

scsi: ufs: mcq: Use active_reqs to check busy in clock scaling

Multi Circular Queue doesn't use outstanding_reqs. However, the UFS clock
scaling functions use outstanding_reqs to determine if there are requests
pending. When MCQ is enabled, this check always returns false.

Hence use active_reqs to check if there are pending requests.

Fixes: eacb139b ("scsi: ufs: core: mcq: Enable multi-circular queue")
Signed-off-by: default avatarAsutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Link: https://lore.kernel.org/r/a24e0d646aac70eae0fc5e05fac0c58bb7e6e680.1678317160.git.quic_asutoshd@quicinc.comSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent be03df3d
...@@ -1500,7 +1500,7 @@ static int ufshcd_devfreq_get_dev_status(struct device *dev, ...@@ -1500,7 +1500,7 @@ static int ufshcd_devfreq_get_dev_status(struct device *dev,
scaling->window_start_t = curr_t; scaling->window_start_t = curr_t;
scaling->tot_busy_t = 0; scaling->tot_busy_t = 0;
if (hba->outstanding_reqs) { if (scaling->active_reqs) {
scaling->busy_start_t = curr_t; scaling->busy_start_t = curr_t;
scaling->is_busy_started = true; scaling->is_busy_started = true;
} else { } else {
...@@ -2118,7 +2118,7 @@ static void ufshcd_clk_scaling_update_busy(struct ufs_hba *hba) ...@@ -2118,7 +2118,7 @@ static void ufshcd_clk_scaling_update_busy(struct ufs_hba *hba)
spin_lock_irqsave(hba->host->host_lock, flags); spin_lock_irqsave(hba->host->host_lock, flags);
hba->clk_scaling.active_reqs--; hba->clk_scaling.active_reqs--;
if (!hba->outstanding_reqs && scaling->is_busy_started) { if (!scaling->active_reqs && scaling->is_busy_started) {
scaling->tot_busy_t += ktime_to_us(ktime_sub(ktime_get(), scaling->tot_busy_t += ktime_to_us(ktime_sub(ktime_get(),
scaling->busy_start_t)); scaling->busy_start_t));
scaling->busy_start_t = 0; scaling->busy_start_t = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment