Commit c607e5e2 authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Linus Walleij

gpio: max77620: Don't shadow error code of platform_get_irq()

The platform_get_irq() returns a positive interrupt number on success and
negative error code on failure (zero shouldn't ever happen in practice, it
would produce a noisy warning). Hence let's return the error code directly
instead of overriding it with -ENODEV.
Suggested-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Link: https://lore.kernel.org/r/20200709171203.12950-5-digetx@gmail.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 78934d88
...@@ -264,12 +264,14 @@ static int max77620_gpio_probe(struct platform_device *pdev) ...@@ -264,12 +264,14 @@ static int max77620_gpio_probe(struct platform_device *pdev)
{ {
struct max77620_chip *chip = dev_get_drvdata(pdev->dev.parent); struct max77620_chip *chip = dev_get_drvdata(pdev->dev.parent);
struct max77620_gpio *mgpio; struct max77620_gpio *mgpio;
int gpio_irq; unsigned int gpio_irq;
int ret; int ret;
gpio_irq = platform_get_irq(pdev, 0); ret = platform_get_irq(pdev, 0);
if (gpio_irq <= 0) if (ret < 0)
return -ENODEV; return ret;
gpio_irq = ret;
mgpio = devm_kzalloc(&pdev->dev, sizeof(*mgpio), GFP_KERNEL); mgpio = devm_kzalloc(&pdev->dev, sizeof(*mgpio), GFP_KERNEL);
if (!mgpio) if (!mgpio)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment