Commit c69b98d1 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

greybus: core: remove uevent handling for gb_connection

As we are going to be removing the struct device from gb_connection,
there is no need to do anything for uevents for them.  So just remove
the code.  It wasn't doing anything anyway, so no functionality is lost
here at all.

As is_gb_connection() is no longer used, that is also removed in this
patch.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarAlex Elder <elder@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
parent 6ea462a4
...@@ -47,7 +47,6 @@ static int greybus_uevent(struct device *dev, struct kobj_uevent_env *env) ...@@ -47,7 +47,6 @@ static int greybus_uevent(struct device *dev, struct kobj_uevent_env *env)
struct gb_module *module = NULL; struct gb_module *module = NULL;
struct gb_interface *intf = NULL; struct gb_interface *intf = NULL;
struct gb_bundle *bundle = NULL; struct gb_bundle *bundle = NULL;
struct gb_connection *connection = NULL;
if (is_gb_endo(dev)) { if (is_gb_endo(dev)) {
/* /*
...@@ -64,21 +63,11 @@ static int greybus_uevent(struct device *dev, struct kobj_uevent_env *env) ...@@ -64,21 +63,11 @@ static int greybus_uevent(struct device *dev, struct kobj_uevent_env *env)
} else if (is_gb_bundle(dev)) { } else if (is_gb_bundle(dev)) {
bundle = to_gb_bundle(dev); bundle = to_gb_bundle(dev);
intf = bundle->intf; intf = bundle->intf;
} else if (is_gb_connection(dev)) {
connection = to_gb_connection(dev);
bundle = connection->bundle;
intf = bundle->intf;
} else { } else {
dev_WARN(dev, "uevent for unknown greybus device \"type\"!\n"); dev_WARN(dev, "uevent for unknown greybus device \"type\"!\n");
return -EINVAL; return -EINVAL;
} }
if (connection) {
// FIXME
// add a uevent that can "load" a connection type
return 0;
}
if (bundle) { if (bundle) {
// FIXME // FIXME
// add a uevent that can "load" a bundle type // add a uevent that can "load" a bundle type
......
...@@ -189,11 +189,6 @@ static inline int is_gb_bundle(const struct device *dev) ...@@ -189,11 +189,6 @@ static inline int is_gb_bundle(const struct device *dev)
return dev->type == &greybus_bundle_type; return dev->type == &greybus_bundle_type;
} }
static inline int is_gb_connection(const struct device *dev)
{
return dev->type == &greybus_connection_type;
}
static inline bool cport_id_valid(struct greybus_host_device *hd, u16 cport_id) static inline bool cport_id_valid(struct greybus_host_device *hd, u16 cport_id)
{ {
return cport_id != CPORT_ID_BAD && cport_id < hd->num_cports; return cport_id != CPORT_ID_BAD && cport_id < hd->num_cports;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment