Commit c832962a authored by Oleksandr Mazur's avatar Oleksandr Mazur Committed by Jakub Kicinski

net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled

Whenever bridge driver hits the max capacity of MDBs, it disables
the MC processing (by setting corresponding bridge option), but never
notifies switchdev about such change (the notifiers are called only upon
explicit setting of this option, through the registered netlink interface).

This could lead to situation when Software MDB processing gets disabled,
but this event never gets offloaded to the underlying Hardware.

Fix this by adding a notify message in such case.

Fixes: 147c1e9b ("switchdev: bridge: Offload multicast disabled")
Signed-off-by: default avatarOleksandr Mazur <oleksandr.mazur@plvision.eu>
Acked-by: default avatarNikolay Aleksandrov <nikolay@nvidia.com>
Link: https://lore.kernel.org/r/20220215165303.31908-1-oleksandr.mazur@plvision.euSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8d2b1a1e
...@@ -82,6 +82,9 @@ static void br_multicast_find_del_pg(struct net_bridge *br, ...@@ -82,6 +82,9 @@ static void br_multicast_find_del_pg(struct net_bridge *br,
struct net_bridge_port_group *pg); struct net_bridge_port_group *pg);
static void __br_multicast_stop(struct net_bridge_mcast *brmctx); static void __br_multicast_stop(struct net_bridge_mcast *brmctx);
static int br_mc_disabled_update(struct net_device *dev, bool value,
struct netlink_ext_ack *extack);
static struct net_bridge_port_group * static struct net_bridge_port_group *
br_sg_port_find(struct net_bridge *br, br_sg_port_find(struct net_bridge *br,
struct net_bridge_port_group_sg_key *sg_p) struct net_bridge_port_group_sg_key *sg_p)
...@@ -1156,6 +1159,7 @@ struct net_bridge_mdb_entry *br_multicast_new_group(struct net_bridge *br, ...@@ -1156,6 +1159,7 @@ struct net_bridge_mdb_entry *br_multicast_new_group(struct net_bridge *br,
return mp; return mp;
if (atomic_read(&br->mdb_hash_tbl.nelems) >= br->hash_max) { if (atomic_read(&br->mdb_hash_tbl.nelems) >= br->hash_max) {
br_mc_disabled_update(br->dev, false, NULL);
br_opt_toggle(br, BROPT_MULTICAST_ENABLED, false); br_opt_toggle(br, BROPT_MULTICAST_ENABLED, false);
return ERR_PTR(-E2BIG); return ERR_PTR(-E2BIG);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment