Commit c856b4b0 authored by Tang Bin's avatar Tang Bin Committed by Greg Kroah-Hartman

USB: EHCI: ehci-mv: fix error handling in mv_ehci_probe()

If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
mv_ehci_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.
Signed-off-by: default avatarZhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: default avatarTang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200508114305.15740-1-tangbin@cmss.chinamobile.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 09806eba
...@@ -167,9 +167,8 @@ static int mv_ehci_probe(struct platform_device *pdev) ...@@ -167,9 +167,8 @@ static int mv_ehci_probe(struct platform_device *pdev)
hcd->regs = ehci_mv->op_regs; hcd->regs = ehci_mv->op_regs;
hcd->irq = platform_get_irq(pdev, 0); hcd->irq = platform_get_irq(pdev, 0);
if (!hcd->irq) { if (hcd->irq < 0) {
dev_err(&pdev->dev, "Cannot get irq."); retval = hcd->irq;
retval = -ENODEV;
goto err_disable_clk; goto err_disable_clk;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment