Commit c8fb7d7e authored by Masahiro Yamada's avatar Masahiro Yamada

kconfig: fix broken dependency in randconfig-generated .config

Running randconfig on arm64 using KCONFIG_SEED=0x40C5E904 (e.g. on v5.5)
produces the .config with CONFIG_EFI=y and CONFIG_CPU_BIG_ENDIAN=y,
which does not meet the !CONFIG_CPU_BIG_ENDIAN dependency.

This is because the user choice for CONFIG_CPU_LITTLE_ENDIAN vs
CONFIG_CPU_BIG_ENDIAN is set by randomize_choice_values() after the
value of CONFIG_EFI is calculated.

When this happens, the has_changed flag should be set.

Currently, it takes the result from the last iteration. It should
accumulate all the results of the loop.

Fixes: 3b9a19e0 ("kconfig: loop as long as we changed some symbols in randconfig")
Reported-by: default avatarVincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 754beeec
...@@ -1312,7 +1312,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode) ...@@ -1312,7 +1312,7 @@ bool conf_set_all_new_symbols(enum conf_def_mode mode)
sym_calc_value(csym); sym_calc_value(csym);
if (mode == def_random) if (mode == def_random)
has_changed = randomize_choice_values(csym); has_changed |= randomize_choice_values(csym);
else { else {
set_all_choice_values(csym); set_all_choice_values(csym);
has_changed = true; has_changed = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment