Commit c974f755 authored by Stephen Kitt's avatar Stephen Kitt Committed by Sam Ravnborg

drm/panel: sony-acx565akm: Use backlight helpers

Instead of retrieving the backlight brightness in struct
backlight_properties manually, and then checking whether the backlight
should be on at all, use backlight_get_brightness() which does all
this and insulates this from future changes.

Instead of manually checking the power state in struct
backlight_properties, use backlight_is_blank().

While we're at it, drop .fb_blank from the initialisation function; it
is deprecated, and this helps make progress towards enabling its
removal. This change makes no functional difference since
FB_BLANK_UNBLANK is the default value.
Signed-off-by: default avatarStephen Kitt <steve@sk2.org>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220616172316.1355133-4-steve@sk2.org
parent d9e74da2
...@@ -298,13 +298,7 @@ static void acx565akm_set_brightness(struct acx565akm_panel *lcd, int level) ...@@ -298,13 +298,7 @@ static void acx565akm_set_brightness(struct acx565akm_panel *lcd, int level)
static int acx565akm_bl_update_status_locked(struct backlight_device *dev) static int acx565akm_bl_update_status_locked(struct backlight_device *dev)
{ {
struct acx565akm_panel *lcd = dev_get_drvdata(&dev->dev); struct acx565akm_panel *lcd = dev_get_drvdata(&dev->dev);
int level; int level = backlight_get_brightness(dev);
if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
dev->props.power == FB_BLANK_UNBLANK)
level = dev->props.brightness;
else
level = 0;
acx565akm_set_brightness(lcd, level); acx565akm_set_brightness(lcd, level);
...@@ -330,8 +324,7 @@ static int acx565akm_bl_get_intensity(struct backlight_device *dev) ...@@ -330,8 +324,7 @@ static int acx565akm_bl_get_intensity(struct backlight_device *dev)
mutex_lock(&lcd->mutex); mutex_lock(&lcd->mutex);
if (dev->props.fb_blank == FB_BLANK_UNBLANK && if (!backlight_is_blank(dev))
dev->props.power == FB_BLANK_UNBLANK)
intensity = acx565akm_get_actual_brightness(lcd); intensity = acx565akm_get_actual_brightness(lcd);
else else
intensity = 0; intensity = 0;
...@@ -349,7 +342,6 @@ static const struct backlight_ops acx565akm_bl_ops = { ...@@ -349,7 +342,6 @@ static const struct backlight_ops acx565akm_bl_ops = {
static int acx565akm_backlight_init(struct acx565akm_panel *lcd) static int acx565akm_backlight_init(struct acx565akm_panel *lcd)
{ {
struct backlight_properties props = { struct backlight_properties props = {
.fb_blank = FB_BLANK_UNBLANK,
.power = FB_BLANK_UNBLANK, .power = FB_BLANK_UNBLANK,
.type = BACKLIGHT_RAW, .type = BACKLIGHT_RAW,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment