Commit ca2bb695 authored by Matthias May's avatar Matthias May Committed by Jakub Kicinski

geneve: do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 3a56f86f ("geneve: handle ipv6 priority like ipv4 tos")
Acked-by: default avatarGuillaume Nault <gnault@redhat.com>
Signed-off-by: default avatarMatthias May <matthias.may@westermo.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b4ab94d6
...@@ -879,8 +879,7 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb, ...@@ -879,8 +879,7 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb,
use_cache = false; use_cache = false;
} }
fl6->flowlabel = ip6_make_flowinfo(RT_TOS(prio), fl6->flowlabel = ip6_make_flowinfo(prio, info->key.label);
info->key.label);
dst_cache = (struct dst_cache *)&info->dst_cache; dst_cache = (struct dst_cache *)&info->dst_cache;
if (use_cache) { if (use_cache) {
dst = dst_cache_get_ip6(dst_cache, &fl6->saddr); dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment