Commit ca5eda5d authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Rafael J. Wysocki

cpufreq: dt: call of_node_put() before error out

If of_match_node() fails, this init function bails out without
calling of_node_put().

Also change of_node_put(of_root) to of_node_put(np); both of them
hold the same pointer, but it seems better to call of_node_put()
against the node returned by of_find_node_by_path().
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5ab666e0
...@@ -79,15 +79,16 @@ static const struct of_device_id machines[] __initconst = { ...@@ -79,15 +79,16 @@ static const struct of_device_id machines[] __initconst = {
static int __init cpufreq_dt_platdev_init(void) static int __init cpufreq_dt_platdev_init(void)
{ {
struct device_node *np = of_find_node_by_path("/"); struct device_node *np = of_find_node_by_path("/");
const struct of_device_id *match;
if (!np) if (!np)
return -ENODEV; return -ENODEV;
if (!of_match_node(machines, np)) match = of_match_node(machines, np);
of_node_put(np);
if (!match)
return -ENODEV; return -ENODEV;
of_node_put(of_root);
return PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt", -1, return PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt", -1,
NULL, 0)); NULL, 0));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment