Commit caa9b6b8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by David S. Miller

net: mdio: mux-multiplexer: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 70edec67
...@@ -85,7 +85,7 @@ static int mdio_mux_multiplexer_probe(struct platform_device *pdev) ...@@ -85,7 +85,7 @@ static int mdio_mux_multiplexer_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int mdio_mux_multiplexer_remove(struct platform_device *pdev) static void mdio_mux_multiplexer_remove(struct platform_device *pdev)
{ {
struct mdio_mux_multiplexer_state *s = platform_get_drvdata(pdev); struct mdio_mux_multiplexer_state *s = platform_get_drvdata(pdev);
...@@ -93,8 +93,6 @@ static int mdio_mux_multiplexer_remove(struct platform_device *pdev) ...@@ -93,8 +93,6 @@ static int mdio_mux_multiplexer_remove(struct platform_device *pdev)
if (s->do_deselect) if (s->do_deselect)
mux_control_deselect(s->muxc); mux_control_deselect(s->muxc);
return 0;
} }
static const struct of_device_id mdio_mux_multiplexer_match[] = { static const struct of_device_id mdio_mux_multiplexer_match[] = {
...@@ -109,7 +107,7 @@ static struct platform_driver mdio_mux_multiplexer_driver = { ...@@ -109,7 +107,7 @@ static struct platform_driver mdio_mux_multiplexer_driver = {
.of_match_table = mdio_mux_multiplexer_match, .of_match_table = mdio_mux_multiplexer_match,
}, },
.probe = mdio_mux_multiplexer_probe, .probe = mdio_mux_multiplexer_probe,
.remove = mdio_mux_multiplexer_remove, .remove_new = mdio_mux_multiplexer_remove,
}; };
module_platform_driver(mdio_mux_multiplexer_driver); module_platform_driver(mdio_mux_multiplexer_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment