Commit cb0aae0e authored by Zheng Bin's avatar Zheng Bin Committed by Dominique Martinet

9p: Fix memory leak in v9fs_mount

v9fs_mount
  v9fs_session_init
    v9fs_cache_session_get_cookie
      v9fs_random_cachetag                     -->alloc cachetag
      v9ses->fscache = fscache_acquire_cookie  -->maybe NULL
  sb = sget                                    -->fail, goto clunk
clunk_fid:
  v9fs_session_close
    if (v9ses->fscache)                        -->NULL
      kfree(v9ses->cachetag)

Thus memleak happens.

Link: http://lkml.kernel.org/r/20200615012153.89538-1-zhengbin13@huawei.com
Fixes: 60e78d2c ("9p: Add fscache support to 9p")
Cc: <stable@vger.kernel.org> # v2.6.32+
Signed-off-by: default avatarZheng Bin <zhengbin13@huawei.com>
Signed-off-by: default avatarDominique Martinet <asmadeus@codewreck.org>
parent 66246641
...@@ -500,10 +500,9 @@ void v9fs_session_close(struct v9fs_session_info *v9ses) ...@@ -500,10 +500,9 @@ void v9fs_session_close(struct v9fs_session_info *v9ses)
} }
#ifdef CONFIG_9P_FSCACHE #ifdef CONFIG_9P_FSCACHE
if (v9ses->fscache) { if (v9ses->fscache)
v9fs_cache_session_put_cookie(v9ses); v9fs_cache_session_put_cookie(v9ses);
kfree(v9ses->cachetag); kfree(v9ses->cachetag);
}
#endif #endif
kfree(v9ses->uname); kfree(v9ses->uname);
kfree(v9ses->aname); kfree(v9ses->aname);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment