Commit cb22f8fb authored by Johan Hovold's avatar Johan Hovold Committed by Kleber Sacilotto de Souza

Input: sur40 - fix interface sanity checks

BugLink: https://bugs.launchpad.net/bugs/1864773

commit 6b32391e upstream.

Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

This in turn could cause the driver to misbehave or trigger a WARN() in
usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: bdb5c57f ("Input: add sur40 driver for Samsung SUR40 (aka MS Surface 2.0/Pixelsense)")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Acked-by: default avatarVladis Dronov <vdronov@redhat.com>
Link: https://lore.kernel.org/r/20191210113737.4016-8-johan@kernel.orgSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 7bd22d8e
...@@ -496,7 +496,7 @@ static int sur40_probe(struct usb_interface *interface, ...@@ -496,7 +496,7 @@ static int sur40_probe(struct usb_interface *interface,
int error; int error;
/* Check if we really have the right interface. */ /* Check if we really have the right interface. */
iface_desc = &interface->altsetting[0]; iface_desc = interface->cur_altsetting;
if (iface_desc->desc.bInterfaceClass != 0xFF) if (iface_desc->desc.bInterfaceClass != 0xFF)
return -ENODEV; return -ENODEV;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment