Commit cb354842 authored by Joern Engel's avatar Joern Engel Committed by Nicholas Bellinger

iscsi-target: remove always-true conditions

Found by coverity.  InitiatorName and InitiatorAlias are static arrays
and therefore always non-NULL.  At some point in the past they may have
been dynamically allocated, but for current code the condition is
useless.  If the intent was to check InitiatorName[0] instead, I cannot
find a use for that either.  Let's get rid of it.
Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent fbecb659
...@@ -669,12 +669,10 @@ static ssize_t lio_target_nacl_show_info( ...@@ -669,12 +669,10 @@ static ssize_t lio_target_nacl_show_info(
} else { } else {
sess = se_sess->fabric_sess_ptr; sess = se_sess->fabric_sess_ptr;
if (sess->sess_ops->InitiatorName) rb += sprintf(page+rb, "InitiatorName: %s\n",
rb += sprintf(page+rb, "InitiatorName: %s\n", sess->sess_ops->InitiatorName);
sess->sess_ops->InitiatorName); rb += sprintf(page+rb, "InitiatorAlias: %s\n",
if (sess->sess_ops->InitiatorAlias) sess->sess_ops->InitiatorAlias);
rb += sprintf(page+rb, "InitiatorAlias: %s\n",
sess->sess_ops->InitiatorAlias);
rb += sprintf(page+rb, "LIO Session ID: %u " rb += sprintf(page+rb, "LIO Session ID: %u "
"ISID: 0x%02x %02x %02x %02x %02x %02x " "ISID: 0x%02x %02x %02x %02x %02x %02x "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment