Commit cbd070a4 authored by Chen Hanxiao's avatar Chen Hanxiao Committed by Pablo Neira Ayuso

ipvs: properly dereference pe in ip_vs_add_service

Use pe directly to resolve sparse warning:

  net/netfilter/ipvs/ip_vs_ctl.c:1471:27: warning: dereference of noderef expression

Fixes: 39b97223 ("ipvs: handle connections started by real-servers")
Signed-off-by: default avatarChen Hanxiao <chenhx.fnst@fujitsu.com>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Acked-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 0935ee60
...@@ -1459,18 +1459,18 @@ ip_vs_add_service(struct netns_ipvs *ipvs, struct ip_vs_service_user_kern *u, ...@@ -1459,18 +1459,18 @@ ip_vs_add_service(struct netns_ipvs *ipvs, struct ip_vs_service_user_kern *u,
if (ret < 0) if (ret < 0)
goto out_err; goto out_err;
/* Bind the ct retriever */
RCU_INIT_POINTER(svc->pe, pe);
pe = NULL;
/* Update the virtual service counters */ /* Update the virtual service counters */
if (svc->port == FTPPORT) if (svc->port == FTPPORT)
atomic_inc(&ipvs->ftpsvc_counter); atomic_inc(&ipvs->ftpsvc_counter);
else if (svc->port == 0) else if (svc->port == 0)
atomic_inc(&ipvs->nullsvc_counter); atomic_inc(&ipvs->nullsvc_counter);
if (svc->pe && svc->pe->conn_out) if (pe && pe->conn_out)
atomic_inc(&ipvs->conn_out_counter); atomic_inc(&ipvs->conn_out_counter);
/* Bind the ct retriever */
RCU_INIT_POINTER(svc->pe, pe);
pe = NULL;
/* Count only IPv4 services for old get/setsockopt interface */ /* Count only IPv4 services for old get/setsockopt interface */
if (svc->af == AF_INET) if (svc->af == AF_INET)
ipvs->num_services++; ipvs->num_services++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment