Commit cc35c3d1 authored by Marcelo Ricardo Leitner's avatar Marcelo Ricardo Leitner Committed by David S. Miller

sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled

Currently, if PMTU discovery is disabled on a given transport, but the
configured value is higher than the actual PMTU, it is likely that we
will get some icmp Frag Needed. The issue is, if PMTU discovery is
disabled, we won't update the information and will issue a
retransmission immediately, which may very well trigger another ICMP,
and another retransmission, leading to a loop.

The fix is to simply not trigger immediate retransmissions if PMTU
discovery is disabled on the given transport.

Changes from v2:
- updated stale comment, noticed by Xin Long
Signed-off-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b707fda2
...@@ -399,20 +399,20 @@ void sctp_icmp_frag_needed(struct sock *sk, struct sctp_association *asoc, ...@@ -399,20 +399,20 @@ void sctp_icmp_frag_needed(struct sock *sk, struct sctp_association *asoc,
return; return;
} }
if (t->param_flags & SPP_PMTUD_ENABLE) { if (!(t->param_flags & SPP_PMTUD_ENABLE))
/* Update transports view of the MTU */ /* We can't allow retransmitting in such case, as the
sctp_transport_update_pmtu(t, pmtu); * retransmission would be sized just as before, and thus we
* would get another icmp, and retransmit again.
*/
return;
/* Update association pmtu. */ /* Update transports view of the MTU */
sctp_assoc_sync_pmtu(asoc); sctp_transport_update_pmtu(t, pmtu);
}
/* Retransmit with the new pmtu setting. /* Update association pmtu. */
* Normally, if PMTU discovery is disabled, an ICMP Fragmentation sctp_assoc_sync_pmtu(asoc);
* Needed will never be sent, but if a message was sent before
* PMTU discovery was disabled that was larger than the PMTU, it /* Retransmit with the new pmtu setting. */
* would not be fragmented, so it must be re-transmitted fragmented.
*/
sctp_retransmit(&asoc->outqueue, t, SCTP_RTXR_PMTUD); sctp_retransmit(&asoc->outqueue, t, SCTP_RTXR_PMTUD);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment