Commit cc4d110e authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Herbert Xu

crypto: scompress - free partially allocated scratch buffers on failure

When allocating the per-CPU scratch buffers, we allocate the source
and destination buffers separately, but bail immediately if the second
allocation fails, without freeing the first one. Fix that.
Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3c083772
...@@ -125,8 +125,11 @@ static int crypto_scomp_alloc_all_scratches(void) ...@@ -125,8 +125,11 @@ static int crypto_scomp_alloc_all_scratches(void)
if (!scomp_src_scratches) if (!scomp_src_scratches)
return -ENOMEM; return -ENOMEM;
scomp_dst_scratches = crypto_scomp_alloc_scratches(); scomp_dst_scratches = crypto_scomp_alloc_scratches();
if (!scomp_dst_scratches) if (!scomp_dst_scratches) {
crypto_scomp_free_scratches(scomp_src_scratches);
scomp_src_scratches = NULL;
return -ENOMEM; return -ENOMEM;
}
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment