Commit cc7fde84 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Greg Kroah-Hartman

vfs: Ignore unlocked mounts in fs_fully_visible

commit ceeb0e5d upstream.

Limit the mounts fs_fully_visible considers to locked mounts.
Unlocked can always be unmounted so considering them adds hassle
but no security benefit.
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32e55895
...@@ -3031,11 +3031,15 @@ bool fs_fully_visible(struct file_system_type *type) ...@@ -3031,11 +3031,15 @@ bool fs_fully_visible(struct file_system_type *type)
if (mnt->mnt.mnt_root != mnt->mnt.mnt_sb->s_root) if (mnt->mnt.mnt_root != mnt->mnt.mnt_sb->s_root)
continue; continue;
/* This mount is not fully visible if there are any child mounts /* This mount is not fully visible if there are any
* that cover anything except for empty directories. * locked child mounts that cover anything except for
* empty directories.
*/ */
list_for_each_entry(child, &mnt->mnt_mounts, mnt_child) { list_for_each_entry(child, &mnt->mnt_mounts, mnt_child) {
struct inode *inode = child->mnt_mountpoint->d_inode; struct inode *inode = child->mnt_mountpoint->d_inode;
/* Only worry about locked mounts */
if (!(mnt->mnt.mnt_flags & MNT_LOCKED))
continue;
if (!S_ISDIR(inode->i_mode)) if (!S_ISDIR(inode->i_mode))
goto next; goto next;
if (inode->i_nlink > 2) if (inode->i_nlink > 2)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment