Commit cd129db9 authored by Sameer Pujar's avatar Sameer Pujar Committed by Juerg Haefliger

ALSA: hda/tegra: clear pending irq handlers

BugLink: https://bugs.launchpad.net/bugs/1811647

commit 63d2a9ec upstream.

Even after disabling interrupts on the module, it could be possible
that irq handlers are still running. System hang is seen during
suspend path. It was found that, there were pending writes on the
HDA bus and clock was disabled by that time.

Above mentioned issue is fixed by clearing any pending irq handlers
before disabling clocks and returning from hda suspend.
Suggested-by: default avatarMohan Kumar <mkumard@nvidia.com>
Suggested-by: default avatarDara Ramesh <dramesh@nvidia.com>
Signed-off-by: default avatarSameer Pujar <spujar@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJuerg Haefliger <juergh@canonical.com>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
parent b796fdec
...@@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct device *dev) ...@@ -249,10 +249,12 @@ static int hda_tegra_suspend(struct device *dev)
struct snd_card *card = dev_get_drvdata(dev); struct snd_card *card = dev_get_drvdata(dev);
struct azx *chip = card->private_data; struct azx *chip = card->private_data;
struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip); struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
struct hdac_bus *bus = azx_bus(chip);
snd_power_change_state(card, SNDRV_CTL_POWER_D3hot); snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
azx_stop_chip(chip); azx_stop_chip(chip);
synchronize_irq(bus->irq);
azx_enter_link_reset(chip); azx_enter_link_reset(chip);
hda_tegra_disable_clocks(hda); hda_tegra_disable_clocks(hda);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment