Commit cd77e75b authored by Dan Carpenter's avatar Dan Carpenter Committed by Pablo Neira Ayuso

netfilter: nf_tables: fix memory leak in nf_tables_parse_netdev_hooks()

Syzbot detected a leak in nf_tables_parse_netdev_hooks().  If the hook
already exists, then the error handling doesn't free the newest "hook".

Reported-by: syzbot+f9d4095107fc8749c69c@syzkaller.appspotmail.com
Fixes: b75a3e83 ("netfilter: nf_tables: allow netdevice to be used only once per flowtable")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 9332d27d
...@@ -1680,6 +1680,7 @@ static int nf_tables_parse_netdev_hooks(struct net *net, ...@@ -1680,6 +1680,7 @@ static int nf_tables_parse_netdev_hooks(struct net *net,
goto err_hook; goto err_hook;
} }
if (nft_hook_list_find(hook_list, hook)) { if (nft_hook_list_find(hook_list, hook)) {
kfree(hook);
err = -EEXIST; err = -EEXIST;
goto err_hook; goto err_hook;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment