Commit ce29ddc4 authored by Mathieu Desnoyers's avatar Mathieu Desnoyers Committed by Ingo Molnar

sched/membarrier: fix missing local execution of ipi_sync_rq_state()

The function sync_runqueues_membarrier_state() should copy the
membarrier state from the @mm received as parameter to each runqueue
currently running tasks using that mm.

However, the use of smp_call_function_many() skips the current runqueue,
which is unintended. Replace by a call to on_each_cpu_mask().

Fixes: 227a4aad ("sched/membarrier: Fix p->mm->membarrier_state racy load")
Reported-by: default avatarNadav Amit <nadav.amit@gmail.com>
Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: stable@vger.kernel.org # 5.4.x+
Link: https://lore.kernel.org/r/74F1E842-4A84-47BF-B6C2-5407DFDD4A4A@gmail.com
parent 50caf9c1
...@@ -471,9 +471,7 @@ static int sync_runqueues_membarrier_state(struct mm_struct *mm) ...@@ -471,9 +471,7 @@ static int sync_runqueues_membarrier_state(struct mm_struct *mm)
} }
rcu_read_unlock(); rcu_read_unlock();
preempt_disable(); on_each_cpu_mask(tmpmask, ipi_sync_rq_state, mm, true);
smp_call_function_many(tmpmask, ipi_sync_rq_state, mm, 1);
preempt_enable();
free_cpumask_var(tmpmask); free_cpumask_var(tmpmask);
cpus_read_unlock(); cpus_read_unlock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment