Commit ceeaddc1 authored by Unnathi Chalicheemala's avatar Unnathi Chalicheemala Committed by Bjorn Andersson

soc: qcom: llcc: Check return value on Broadcast_OR reg read

Commit c72ca343 ("soc: qcom: llcc: Add v4.1 HW version support")
introduced a new 4.1 if statement in llcc_update_act_ctrl() without
considering that ret might be overwritten. So, add return value check
after Broadcast_OR register read in llcc_update_act_ctrl().

Fixes: c72ca343 ("soc: qcom: llcc: Add v4.1 HW version support")
Signed-off-by: default avatarUnnathi Chalicheemala <quic_uchalich@quicinc.com>
Reviewed-by: default avatarElliot Berman <quic_eberman@quicinc.com>
Reviewed-by: default avatarMukesh Ojha <quic_mojha@quicinc.com>
Link: https://lore.kernel.org/r/20240212183515.433873-1-quic_uchalich@quicinc.comSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent c8f349ac
......@@ -859,6 +859,8 @@ static int llcc_update_act_ctrl(u32 sid,
ret = regmap_read_poll_timeout(drv_data->bcast_regmap, status_reg,
slice_status, !(slice_status & status),
0, LLCC_STATUS_READ_DELAY);
if (ret)
return ret;
if (drv_data->version >= LLCC_VERSION_4_1_0_0)
ret = regmap_write(drv_data->bcast_regmap, act_clear_reg,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment