Commit cf00b330 authored by Jonathan Cameron's avatar Jonathan Cameron Committed by Dan Williams

cxl/mbox: Add a check on input payload size

A bug in the LSA code resulted in transfers slightly larger
than the mailbox size. Let us make it easier to catch similar
issues in future by adding a low level check.
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20220815154044.24733-2-Jonathan.Cameron@huawei.comSigned-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 9abf2313
...@@ -174,7 +174,7 @@ int cxl_mbox_send_cmd(struct cxl_dev_state *cxlds, u16 opcode, void *in, ...@@ -174,7 +174,7 @@ int cxl_mbox_send_cmd(struct cxl_dev_state *cxlds, u16 opcode, void *in,
}; };
int rc; int rc;
if (out_size > cxlds->payload_size) if (in_size > cxlds->payload_size || out_size > cxlds->payload_size)
return -E2BIG; return -E2BIG;
rc = cxlds->mbox_send(cxlds, &mbox_cmd); rc = cxlds->mbox_send(cxlds, &mbox_cmd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment