Commit d1249ba7 authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron

iio: dac: ti-dac7311: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-8-caihuoqing@baidu.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 7051c121
...@@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi) ...@@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi)
ti_dac->resolution = spec->resolution; ti_dac->resolution = spec->resolution;
ti_dac->vref = devm_regulator_get(dev, "vref"); ti_dac->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(ti_dac->vref)) { if (IS_ERR(ti_dac->vref))
dev_err(dev, "error to get regulator\n"); return dev_err_probe(dev, PTR_ERR(ti_dac->vref),
return PTR_ERR(ti_dac->vref); "error to get regulator\n");
}
ret = regulator_enable(ti_dac->vref); ret = regulator_enable(ti_dac->vref);
if (ret < 0) { if (ret < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment