Commit d21a06d5 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

sfc: drop unnecessary list_empty

list_for_each_safe is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

<smpl>
@@
expression x,e;
iterator name list_for_each_safe;
statement S;
identifier i,j;
@@

-if (!(list_empty(x))) {
   list_for_each_safe(i,j,x) S
- }
 ... when != i
     when != j
(
  i = e;
|
? j = e;
)
</smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Acked-by: default avatarEdward Cree <ecree@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a57066b1
...@@ -1154,17 +1154,15 @@ static void efx_ptp_drop_time_expired_events(struct efx_nic *efx) ...@@ -1154,17 +1154,15 @@ static void efx_ptp_drop_time_expired_events(struct efx_nic *efx)
/* Drop time-expired events */ /* Drop time-expired events */
spin_lock_bh(&ptp->evt_lock); spin_lock_bh(&ptp->evt_lock);
if (!list_empty(&ptp->evt_list)) { list_for_each_safe(cursor, next, &ptp->evt_list) {
list_for_each_safe(cursor, next, &ptp->evt_list) { struct efx_ptp_event_rx *evt;
struct efx_ptp_event_rx *evt;
evt = list_entry(cursor, struct efx_ptp_event_rx,
evt = list_entry(cursor, struct efx_ptp_event_rx, link);
link); if (time_after(jiffies, evt->expiry)) {
if (time_after(jiffies, evt->expiry)) { list_move(&evt->link, &ptp->evt_free_list);
list_move(&evt->link, &ptp->evt_free_list); netif_warn(efx, hw, efx->net_dev,
netif_warn(efx, hw, efx->net_dev, "PTP rx event dropped\n");
"PTP rx event dropped\n");
}
} }
} }
spin_unlock_bh(&ptp->evt_lock); spin_unlock_bh(&ptp->evt_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment