Commit d2598bb8 authored by Alex Dewar's avatar Alex Dewar Committed by Jason Gunthorpe

RDMA/qib: Remove superfluous fallthrough statements

Commit 36a8f01c ("IB/qib: Add congestion control agent
implementation") erroneously marked a couple of switch cases as /*
FALLTHROUGH */, which were later converted to fallthrough statements by
commit df561f66 ("treewide: Use fallthrough pseudo-keyword"). This
triggered a Coverity warning about unreachable code.

Remove the fallthrough statements.

Link: https://lore.kernel.org/r/20200825171242.448447-1-alex.dewar90@gmail.com
Addresses-Coverity: ("Unreachable code")
Fixes: 36a8f01c ("IB/qib: Add congestion control agent implementation")
Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Reviewed-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6989aa62
...@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags, ...@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
ret = cc_get_congestion_control_table(ccp, ibdev, port); ret = cc_get_congestion_control_table(ccp, ibdev, port);
goto bail; goto bail;
fallthrough;
default: default:
ccp->status |= IB_SMP_UNSUP_METH_ATTR; ccp->status |= IB_SMP_UNSUP_METH_ATTR;
ret = reply((struct ib_smp *) ccp); ret = reply((struct ib_smp *) ccp);
...@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags, ...@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
ret = cc_set_congestion_control_table(ccp, ibdev, port); ret = cc_set_congestion_control_table(ccp, ibdev, port);
goto bail; goto bail;
fallthrough;
default: default:
ccp->status |= IB_SMP_UNSUP_METH_ATTR; ccp->status |= IB_SMP_UNSUP_METH_ATTR;
ret = reply((struct ib_smp *) ccp); ret = reply((struct ib_smp *) ccp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment