Commit d3264799 authored by Tao Ma's avatar Tao Ma Committed by Mark Fasheh

ocfs2: Fix check of return value of ocfs2_start_trans() in xattr.c.

On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM),
so we should check whether handle is NULL. Fix them to use IS_ERR().
Jan has made the patch for other part in ocfs2(thank Jan for it), so
this is just the fix for fs/ocfs2/xattr.c.
Signed-off-by: default avatarTao Ma <tao.ma@oracle.com>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
Signed-off-by: default avatarMark Fasheh <mfasheh@suse.com>
parent b99835c1
...@@ -4092,7 +4092,7 @@ static int ocfs2_xattr_value_update_size(struct inode *inode, ...@@ -4092,7 +4092,7 @@ static int ocfs2_xattr_value_update_size(struct inode *inode,
handle_t *handle = NULL; handle_t *handle = NULL;
handle = ocfs2_start_trans(osb, 1); handle = ocfs2_start_trans(osb, 1);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = -ENOMEM;
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
...@@ -4259,7 +4259,7 @@ static int ocfs2_rm_xattr_cluster(struct inode *inode, ...@@ -4259,7 +4259,7 @@ static int ocfs2_rm_xattr_cluster(struct inode *inode,
} }
handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = -ENOMEM;
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment